Continue work on C++ packaging #97
Conversation
…est of the build can retrieve them.
from the packaging yaml, saving the artifacts
…e .sh file (to be added).
| Hi Vimanyu, Could you take a look at this PR? The manual workflow is currently passing with the most recent run: https://github.com/firebase/firebase-cpp-sdk/actions/runs/178862172 I want to get this merged to avoid monolithic PRs. As we switch from .sh to .py scripts for building I'll update these scripts in a subsequent CL. |
| cmake --build . | ||
| python demumble_test.py | ||
| cd - | ||
| mkdir -p packaging-tools |
There was a problem hiding this comment.
Could this mkdir mask issues from the previous step?
There was a problem hiding this comment.
I don't think so, if there are any issues then the script won't get this far.
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: firebase-cpp-sdk-ios-${{ matrix.architecture }} | ||
| path: firebase-cpp-sdk-ios-${{ matrix.architecture }}.tgz |
There was a problem hiding this comment.
By any chance, will we need a version number for these artifacts?
There was a problem hiding this comment.
AFAIK these artifacts are local to the workflow? So I don't think they need versioning. Later on in the workflow, all of these will be joined together into a single binary SDK artifact, and that will be versioned.
There was a problem hiding this comment.
Yes, can confirm - they're scoped by the workflow.
4 participants
After building packaging tools, upload them into an artifact so the rest of the build can retrieve them.
Also contains basic versions of the iOS and Android prereqs and build scripts, and build jobs added to the workflow. Uploads the built iOS and Android SDK artifacts as well.
Desktop needs to wait until desktop workflow is moved into prereqs + build scripts.