Skip to content

Minor fixes to Firestore Source Tests. #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021
Merged

Minor fixes to Firestore Source Tests. #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Minor fixes to Firestore Source Tests.
  • Loading branch information
@ehsannas
ehsannas committed May 5, 2021
commit 27a8bfa5dd5f99ac7514d40dcb164b45dc0fc5b0
6 changes: 4 additions & 2 deletions firestore/integration_test_internal/src/source_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#include <future>
#include <map>
#include <string>

#include "firebase/firestore.h"
#include "firestore_integration_test.h"
Expand Down Expand Up @@ -257,7 +259,7 @@ TEST_F(SourceTest, GetDocumentWhileOfflineWithDifferentGetOptions) {
error_promise.set_value(error_code);
});
// Note that future::get() will wait until the future has a valid result and
// retrieves it. Calling wait() before get() is not needed.
// retrieve it. Calling wait() before get() is not needed.
Error error_code = error_future.get();
EXPECT_EQ(error_code, kErrorNone);

Expand Down Expand Up @@ -311,7 +313,7 @@ TEST_F(SourceTest, GetCollectionWhileOfflineWithDifferentGetOptions) {
error_promise.set_value(error_code);
});
// Note that future::get() will wait until the future has a valid result and
// retrieves it. Calling wait() before get() is not needed.
// retrieve it. Calling wait() before get() is not needed.
Error error_code = error_future.get();
EXPECT_EQ(error_code, kErrorNone);

Expand Down