Skip to content

Minor fixes to Firestore Source Tests. #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

Minor fixes to Firestore Source Tests. #411

merged 1 commit into from
May 6, 2021

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented May 5, 2021

No description provided.

@ehsannas ehsannas requested a review from var-const May 5, 2021 18:42
@ehsannas ehsannas self-assigned this May 5, 2021
@google-cla google-cla bot added the cla: yes label May 5, 2021
var-const
var-const approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@var-const var-const left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up!
@ehsannas ehsannas merged commit ba13765 into firebase:main May 6, 2021
@ehsannas ehsannas deleted the add-source-tests-2 branch May 6, 2021 16:02
@firebase firebase locked and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

2 participants

@ehsannas @var-const