chore: upgrade @ember/string to version 4 #2993
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Test Results0 tests - 674 0 ✅ - 626 0s ⏱️ - 9m 24s For more details on these parsing errors, see this check. Results for commit d164589. ± Comparison against base commit 5d1321f. ♻️ This comment has been updated with latest results. |
VasylMarchuk force-pushed the upgrade-ember-string branch from 8830662 to 623fa4e Compare 
Bundle ReportChanges will increase total bundle size by 11.54kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
VasylMarchuk force-pushed the upgrade-ember-string branch from c822619 to bdc774c Compare VasylMarchuk force-pushed the upgrade-ember-string branch from bdc774c to b7adba5 Compare 3 tasks
VasylMarchuk force-pushed the upgrade-ember-string branch from b7adba5 to bfcb1e7 Compare VasylMarchuk force-pushed the upgrade-ember-string branch from bfcb1e7 to 1d4dc72 Compare 
VasylMarchuk force-pushed the upgrade-ember-string branch from 1d4dc72 to d164589 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow-up to #2949
Brief
This upgrades
@ember/stringto version4.0.1, as it's now the default generated byember newin ember5.12Details
Everything else is updated and ready, except for
ember-cli-mirage, created an issue here and we must wait for it to be fixed.Checklist
[percy]in the message to trigger)