Upgrade Ember.js to version 5.12

[VasylMarchuk]

Closes #2926

Brief

This upgrades Ember.js from version 5.8 to version 5.12

Details

• Sequentially upgraded ember to 5.9, 5.10, 5.11, 5.12
• Fixed ember-cli-deprecation-workflow and updated it to version 3.4.0
• Marked Store as still inheriting from EmberObject and enabled the deprecation warning instead of failing with error
• Added ember-inflector as a dependency, we import it in several places
  • This way we can control the version instead of relying on some of other packages having it as peer dependency
• Renamed ScreencastsTabComponent to ScreencastsTabController (typo)
• Fixed a null-reference error in console when running tests

Prototype extensions

Array prototype extensions are still available until Ember 6, so we can skip them in this PR, created a separate draft PR with the first attempt at fixing.

I tried but couldn't enable the deprecation warnings as this causes eslint --fix to fix them in over 600 files.

Follow-up PRs

• Default blueprint now generates components without Component ending (MyButton instead of MyButtonComponent). Renamed all our components in a separate PR
• Improved our NPM tasks in a separate PR
• Default blueprint now adds @ember/string version 4 but ember-cli-mirage hasn't been updated to support it, made a separate draft PR and created an issue
• Array prototype extensions became deprecated in 5.10, made an experimental/draft PR using the officially suggested method, will make another one using Ember.A approach

Links

• Changes from 5.8 to 5.12
• 5.9 release announcement
• 5.10 release announcement
• 5.11 release announcement
• 5.12 release announcement
• Deprecations added in v5
• Deprecation Guide for Deprecate array prototype extensions
• RFC for Deprecate array prototype extensions
• RFC for First-class component templates (removal of Component ending from component classes is supposedly part of this)

Previous Ember upgrade PRs

• Upgrade to Ember 5 #1161
• Update Ember.js to version 5.8 #2075

Checklist

• I've thoroughly self-reviewed my changes
• I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
• I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch upgrade-ember-to-5.12

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Test Results

647 tests  ±0   599 ✅ ±0   8m 44s ⏱️ +3s
  1 suites ±0    48 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 9e2e846. ± Comparison against base commit b4f7e3f.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codecov]

Bundle Report

Changes will decrease total bundle size by 2.12kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
client-array-push	38.5MB	-2.12kB (-0.01%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
assets/chunk.*.js	-32 bytes	26.57kB	-0.12%
assets/chunk.*.js	-88 bytes	59.8kB	-0.15%
assets/chunk.*.js	-78 bytes	331.37kB	-0.02%
assets/chunk.*.js	-65 bytes	27.16kB	-0.24%
assets/chunk.*.js	-909 bytes	3.14MB	-0.03%
assets/chunk.*.js	-10 bytes	11.89kB	-0.08%
assets/chunk.*.js	-16 bytes	230.37kB	-0.01%
assets/chunk.*.js	-52 bytes	70.68kB	-0.07%
assets/chunk.*.js	1 bytes	15.26kB	0.01%
assets/chunk.*.js	133 bytes	27.23kB	0.49%
assets/chunk.*.js	-560 bytes	406.82kB	-0.14%
assets/chunk.*.js	-20 bytes	301.63kB	-0.01%
assets/chunk.*.js	-212 bytes	107.37kB	-0.2%
assets/chunk.*.js	-215 bytes	182.04kB	-0.12%

Files in assets/chunk.*.js:

• ./controllers/course/stage/screencasts.ts → Total Size: 4.75kB

[VasylMarchuk]

@coderabbitai review

[rohitpaulk]

Added q related to the args.user change - everything else looks good!