Skip to content
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ module.exports = {
},
],

'ember/no-array-prototype-extensions': 'off', // Get to this later
'ember/no-array-prototype-extensions': 'off', // FIXME: Change to error - prototype extensions are deprecated since Ember 5.10
'ember/no-empty-glimmer-component-classes': 'off', // It's useful to have empty components since the names are shown in devtools
'ember/no-runloop': 'off', // Run-loop isn't deprecated yet. Switching to ember-concurrency would require a lot of effort. We can use ember-lifeline as a drop-in replacement whenever run-loop becomes deprecated.
'@typescript-eslint/member-ordering': [
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ or against a local instance of `core`. Visit the `core` repo for setup instructi
- Add `FASTBOOT_DISABLED=true` to your local `.env` file to disable FastBoot completely
- You can override it by passing `FASTBOOT_DISABLED=""` in the command line
- NPM task `start` runs with FastBoot **disabled**
- NPM tasks `start:fastboot` runs with FastBoot **enabled**
- NPM task `start:fastboot` runs with FastBoot **enabled**

## Running tests

Expand Down
1 change: 1 addition & 0 deletions app/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Application from '@ember/application';
import Resolver from 'ember-resolver';
import loadInitializers from 'ember-load-initializers';
import config from 'codecrafters-frontend/config/environment';
import 'codecrafters-frontend/config/deprecation-workflow';
import * as Sentry from '@sentry/ember';
import 'ember-basic-dropdown/styles';
import 'ember-animated/index';
Expand Down
6 changes: 6 additions & 0 deletions app/config/deprecation-workflow.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import setupDeprecationWorkflow from 'ember-cli-deprecation-workflow';

setupDeprecationWorkflow({
throwOnUnhandled: true,
workflow: [],
});
2 changes: 1 addition & 1 deletion app/controllers/course/stage/screencasts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type ModelType = {
activeRepository: RepositoryModel;
};

export default class ScreencastsTabComponent extends Controller {
export default class ScreencastsTabController extends Controller {
queryParams = ['selectedScreencastId'];

declare model: ModelType;
Expand Down
10 changes: 0 additions & 10 deletions config/deprecation-workflow.js

This file was deleted.

2 changes: 1 addition & 1 deletion config/ember-cli-update.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"packages": [
{
"name": "ember-cli",
"version": "5.8.0",
"version": "5.12.0",
"blueprints": [
{
"name": "app",
Expand Down
6 changes: 6 additions & 0 deletions ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ module.exports = function (defaults) {
],
},

emberData: {
deprecations: {
DEPRECATE_STORE_EXTENDS_EMBER_OBJECT: false, // Remove this after migrating off array prottype extensin usages
},
},

'@embroider/macros': {
setConfig: {
'@ember-data/store': {
Expand Down
Loading