Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

AQL String Functions: Describe caseInsensitive parameter, improve examples and port to @EXAMPLE_AQL #878

Merged
merged 18 commits into from
Feb 8, 2022
Merged

AQL String Functions: Describe caseInsensitive parameter, improve examples and port to @EXAMPLE_AQL #878

merged 18 commits into from
Feb 8, 2022

Conversation

Simran-B
Copy link
Collaborator

@Simran-B Simran-B commented Jan 20, 2022 •
edited
Loading

  • caseInsensitive parameter not sometimes missing, sometimes in the wrong place.
  • Examples ported to @EXAMPLE_AQL (3.10 only)
  • Added a few more examples, renamed a couple to match convention, removed some that didn't provide additional value. Left example queries involving a View unchanged.
  • Modified some descriptions and examples that didn't match actual behavior (likely changed around 3.0 noticed)
  • Factored out regular expression syntax description and moved it to the end of the page

https://jenkins.arangodb.biz:3456/view/Documentation/job/arangodb-ANY-examples/1605/
@cla-bot cla-bot bot added the cla-signed label Jan 20, 2022
@Simran-B Simran-B self-assigned this Jan 20, 2022
@ansoboleva ansoboleva self-requested a review January 27, 2022 08:51
@Simran-B
Convert examples to @EXAMPLE_AQL
1b15bbc 
Also added/renamed/modified/removed some examples. Removed result comments. Left a few examples as plain js code blocks that involve querying a View.
@Simran-B Simran-B changed the title AQL String Functions: caseInsensitive parameter not described AQL String Functions: Describe caseInsensitive parameter, improve examples and port to @EXAMPLE_AQL Jan 27, 2022
Simran-B
Simran-B commented Jan 27, 2022
View reviewed changes
@cla-bot

This comment was marked as spam.

Sign in to view
@cla-bot cla-bot bot removed the cla-signed label Feb 3, 2022
@cla-bot

This comment was marked as spam.

Sign in to view
@Simran-B Simran-B mentioned this pull request Feb 3, 2022
Merged
@cla-bot

This comment was marked as spam.

Sign in to view
@cla-bot

This comment was marked as spam.

Sign in to view
@Simran-B Simran-B marked this pull request as ready for review February 3, 2022 15:52
@cw00dw0rd
Copy link
Contributor

@cla-bot check
@cla-bot

This comment was marked as spam.

Sign in to view
@cla-bot
Copy link

cla-bot bot commented Feb 3, 2022

The avocado-loving overlords have requested I re-evaluate this PR. The bot abides.
@cw00dw0rd
Copy link
Contributor

@cla-bot check
@cla-bot

This comment was marked as spam.

Sign in to view
@cla-bot
Copy link

cla-bot bot commented Feb 3, 2022

The avocado-loving overlords have requested I re-evaluate this PR. The bot abides.
@cla-bot

This comment was marked as spam.

Sign in to view
@Simran-B
Copy link
Collaborator Author

Simran-B commented Feb 3, 2022

There are issues with backslashes in examples. Might need to double escape...

image
@cw00dw0rd
Copy link
Contributor

@cla-bot check
@cla-bot

This comment was marked as spam.

Sign in to view
@cla-bot
Copy link

cla-bot bot commented Feb 3, 2022

The avocado-loving overlords have requested I re-evaluate this PR. The bot abides.
@Simran-B
Properly escape backslashes in @EXAMPLE_AQL
aa73cdd 
JSON escape sequences need two backslashes in AQL examples (\\t, \\r, \\n), shorthand character classes four (\\\\s, \\\\d, \\\\., and so on). Only half of the amount will display in the result.
@Simran-B
Merge branch 'main' of https://github.com/arangodb/docs into aql-rege…
dc566f3 
…x-case-insensitive
@cla-bot

This comment was marked as spam.

Sign in to view
@Simran-B
Copy link
Collaborator Author

Simran-B commented Feb 4, 2022

Backslash escape issues fixed:
image
@cla-bot
Copy link

cla-bot bot commented Feb 8, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jenkins.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
@cla-bot
Copy link

cla-bot bot commented Feb 8, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jenkins.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
@cla-bot
Copy link

cla-bot bot commented Feb 8, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jenkins.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
ansoboleva
ansoboleva approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@ansoboleva ansoboleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed
@ansoboleva ansoboleva merged commit 0dab932 into main Feb 8, 2022
@ansoboleva ansoboleva deleted the aql-regex-case-insensitive branch February 8, 2022 09:15
@Simran-B Simran-B mentioned this pull request Mar 28, 2022
Merged
Simran-B added a commit that referenced this pull request Apr 19, 2022
@Simran-B
Bring back changes done in #878
03a9574 
Content changes merged in 0dab932 were accidentally reverted by 4c6755c (#883)
@Simran-B Simran-B mentioned this pull request Apr 19, 2022
Merged
ansoboleva added a commit that referenced this pull request Apr 21, 2022
@Simran-B @ansoboleva
Redo changes lost around Februrary 7/8th (#979)
4ed93ee 
* Bring back changes done in #878 Content changes merged in 0dab932 were accidentally reverted by 4c6755c (#883) * Redo #952 (with simplification) that was accidentally undone by #954 * Add line breaks before API descriptions Fixes DocuBlock rendering issue. The first list item wasn't rendered if a text started with a list * Update examples for 3.10 in redo-commits-2022-02 at 2022-04-21T11:13:36+02:00 Co-authored-by: Jenkins <jenkins@arangodb.com> Co-authored-by: arangodb-release-bot <anastasia.soboleva@arangodb.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

9 Ready to Merge

3 participants

@Simran-B @cw00dw0rd @ansoboleva