Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Conversation

cpjulia
Copy link
Contributor

@cpjulia cpjulia commented Jan 26, 2022

Documentation for arangodb/arangodb#15493

@cla-bot cla-bot bot added the cla-signed label Jan 26, 2022
@cpjulia cpjulia mentioned this pull request Jan 26, 2022
18 tasks
@ansoboleva ansoboleva added this to the 3.10 milestone Jan 26, 2022
@ansoboleva ansoboleva requested a review from jsteemann January 26, 2022 08:11
as an object. A parameter that was set upon server start can be unset by
providing its name as a key and `false` as value.
The usage is as in the example:
`arango.PUT("/_admin/log/structured/", {"database": true, "url": false})`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't put arango.PUT(...) examples into the docs because this is more or less an internal way of making requests. I think here we should simply refer to the HTTP API to adjust the parameters.
The HTTP API should of course be documented as well, but I think this is missing right now from this PR.

Suggested change
`arango.PUT("/_admin/log/structured/", {"database": true, "url": false})`
`arango.PUT("/_admin/log/structured", {"database": true, "url": false})`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we shouldn't put arango.PUT(...) examples into our docs because this is more or less an internal way of making requests that is not advertised to end users. Really.

cpjulia and others added 8 commits January 26, 2022 13:05
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Copy link
Contributor

@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my non-addressed review comment.

Copy link
Contributor

@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cla-bot

This comment was marked as spam.

@cla-bot cla-bot bot removed the cla-signed label Feb 1, 2022
@ansoboleva ansoboleva self-requested a review February 2, 2022 09:50
@ansoboleva
Copy link
Collaborator

@Simran-B please fix the error with missing arangod options.

@cla-bot

This comment was marked as spam.

@cla-bot

This comment was marked as spam.

@Simran-B
Copy link
Collaborator

Simran-B commented Feb 3, 2022

Fixed Netlify builds via #895.

@ansoboleva ansoboleva removed the 9 WIP label Feb 7, 2022
@cla-bot
Copy link

cla-bot bot commented Feb 8, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jenkins.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
@cla-bot
Copy link

cla-bot bot commented Feb 8, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jenkins.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
@cla-bot
Copy link

cla-bot bot commented Feb 8, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jenkins.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
Copy link
Collaborator

@ansoboleva ansoboleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@ansoboleva ansoboleva merged commit 7fe1d1b into main Feb 8, 2022
@ansoboleva ansoboleva deleted the feature/ORCO-18 branch February 8, 2022 11:00
Simran-B added a commit that referenced this pull request Apr 19, 2022
Content changes merged in 0dab932 were accidentally reverted by 4c6755c (#883)
ansoboleva added a commit that referenced this pull request Apr 21, 2022
* Bring back changes done in #878 Content changes merged in 0dab932 were accidentally reverted by 4c6755c (#883) * Redo #952 (with simplification) that was accidentally undone by #954 * Add line breaks before API descriptions Fixes DocuBlock rendering issue. The first list item wasn't rendered if a text started with a list * Update examples for 3.10 in redo-commits-2022-02 at 2022-04-21T11:13:36+02:00 Co-authored-by: Jenkins <jenkins@arangodb.com> Co-authored-by: arangodb-release-bot <anastasia.soboleva@arangodb.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants