- Notifications
You must be signed in to change notification settings - Fork 57
Added documentation for ORCO-18 #883
Conversation
3.10/programs-arangod-log.md Outdated
as an object. A parameter that was set upon server start can be unset by | ||
providing its name as a key and `false` as value. | ||
The usage is as in the example: | ||
`arango.PUT("/_admin/log/structured/", {"database": true, "url": false})` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't put arango.PUT(...)
examples into the docs because this is more or less an internal way of making requests. I think here we should simply refer to the HTTP API to adjust the parameters.
The HTTP API should of course be documented as well, but I think this is missing right now from this PR.
`arango.PUT("/_admin/log/structured/", {"database": true, "url": false})` | |
`arango.PUT("/_admin/log/structured", {"database": true, "url": false})` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we shouldn't put arango.PUT(...)
examples into our docs because this is more or less an internal way of making requests that is not advertised to end users. Really.
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my non-addressed review comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment was marked as spam.
This comment was marked as spam.
@Simran-B please fix the error with missing arangod options. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Fixed Netlify builds via #895. |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jenkins.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jenkins.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jenkins.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
* Bring back changes done in #878 Content changes merged in 0dab932 were accidentally reverted by 4c6755c (#883) * Redo #952 (with simplification) that was accidentally undone by #954 * Add line breaks before API descriptions Fixes DocuBlock rendering issue. The first list item wasn't rendered if a text started with a list * Update examples for 3.10 in redo-commits-2022-02 at 2022-04-21T11:13:36+02:00 Co-authored-by: Jenkins <jenkins@arangodb.com> Co-authored-by: arangodb-release-bot <anastasia.soboleva@arangodb.com>
Documentation for arangodb/arangodb#15493