Skip to content

Test cases for upper.py #9948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Test cases for upper.py #9948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d31e500
Test cases for upper.py
LucasHBD Oct 7, 2023
271b6b2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 7, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions strings/upper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ def upper(word: str) -> str:
'WHAT'
>>> upper("wh[]32")
'WH[]32'
>>> upper("WH[]3_aA2")
'WH[]3_AA2'
>>> upper("bomdia&compania")
'BOMDIA&COMPANIA'
Comment on lines +13 to +16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that these cases don't add much additional value because they don't really test any cases that the previous tests don't already cover. Instead, could we have a test for the empty string and a test for a string with no letters?
"""

# Converting to ascii value int value and checking to see if char is a lower letter
Expand Down