Test cases for upper.py #9948
Closed
Test cases for upper.py #9948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
algorithms-keeper bot added tests are failing 
tianyizheng02 requested changes Oct 8, 2023
Comment on lines +13 to +16
| >>> upper("WH[]3_aA2") | ||
| 'WH[]3_AA2' | ||
| >>> upper("bomdia&compania") | ||
| 'BOMDIA&COMPANIA' |
There was a problem hiding this comment.
I feel that these cases don't add much additional value because they don't really test any cases that the previous tests don't already cover. Instead, could we have a test for the empty string and a test for a string with no letters?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Describe your change: