Posted on Jan 17, 2021 • Edited on Jun 14, 2021 • Originally published at maximilianocontieri.com

Code Smell 55 - Object Orgy

#codenewbie #codesmell #webdev #tutorial

If you see your objects as data holders you will violate their encapsulation, but you shouldn't, as in real life, you should always ask for consent.

TL;DR: Don't mess with other object's data.

Problems

Information Hiding Violation
Encapsulation Violation
Coupling

Solutions

Couple to interfaces and behavior, never data.

Sample Code

Wrong

<? final class Point { public $x; public $y; } final class DistanceCalculator { function distanceBetween(Point $origin, Point $destination) { return sqrt((($destination->x - $origin->x) ^ 2) + (($destination->y - $origin->y) ^ 2)); } }

Right

<? final class Point { private $rho; private $theta; public function x() { return $this->rho * cos($this->theta); } public function y() { return $this->rho * sin($this->theta); } } final class DistanceCalculator { function distanceBetween(Point $origin, Point $destination) { return sqrt((($destination->x() - $origin->x() ^ 2) + (($destination->y() - $origin->y()) ^ 2))); } }