- Notifications
You must be signed in to change notification settings - Fork 316
fix: toggle DENO_NO_PACKAGE_JSON conditionally #4372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 19325748827Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
840f37d to 13e2832 Compare DENO_NO_PACKAGE_JSONDENO_NO_PACKAGE_JSON conditionally 8c43045 to d5a211c Compare f135c39 to 27988b5 Compare | Could you guide me on how to correctly reference I just need to be able to reference it within the Bundle, and I'd appreciate it if you could let me know any way to do that. 🥹 |
Yea kinda of. Because adding variadic args is backwards compatible. Let me think about it a bit more too. |
What kind of change does this PR introduce?
Enhancement
Description
Make CLI conditionally toggle
DENO_NO_PACKAGE_JSONbased on what files are in each function folder.This only applies when deploying functions locally/Docker and not using the deploy api.
Related supabase/supabase#38402
Towards FUNC-304