Skip to content

Conversation

@nyannyacha
Copy link
Contributor

@nyannyacha nyannyacha commented Oct 28, 2025

What kind of change does this PR introduce?

Enhancement

Description

Make CLI conditionally toggle DENO_NO_PACKAGE_JSON based on what files are in each function folder.
This only applies when deploying functions locally/Docker and not using the deploy api.

Related supabase/supabase#38402
Towards FUNC-304

@nyannyacha nyannyacha requested a review from a team as a code owner October 28, 2025 07:39
@coveralls
Copy link

coveralls commented Oct 28, 2025

Pull Request Test Coverage Report for Build 19325748827

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 160 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.3%) to 54.419%

Files with Coverage Reduction New Missed Lines %
internal/bans/get/get.go 1 0.0%
internal/utils/api.go 2 87.63%
internal/branches/delete/delete.go 3 0.0%
internal/branches/get/get.go 3 0.0%
internal/inspect/vacuum_stats/vacuum_stats.go 3 70.0%
internal/gen/keys/keys.go 5 12.9%
cmd/projects.go 8 0.0%
internal/utils/connect.go 15 89.04%
internal/projects/create/create.go 18 43.0%
internal/link/link.go 22 73.8%
Totals Coverage Status
Change from base Build 19065008112: -0.3%
Covered Lines: 6361
Relevant Lines: 11689

💛 - Coveralls
@nyannyacha nyannyacha force-pushed the ny/add-use-pkg-json-flag branch from 840f37d to 13e2832 Compare October 29, 2025 11:27
@nyannyacha nyannyacha changed the title fix: introduce new flag in function section to handle DENO_NO_PACKAGE_JSON fix: toggle DENO_NO_PACKAGE_JSON conditionally Oct 29, 2025
@nyannyacha nyannyacha marked this pull request as draft October 29, 2025 11:42
@nyannyacha nyannyacha force-pushed the ny/add-use-pkg-json-flag branch 2 times, most recently from 8c43045 to d5a211c Compare November 4, 2025 02:08
@nyannyacha nyannyacha force-pushed the ny/add-use-pkg-json-flag branch from f135c39 to 27988b5 Compare November 4, 2025 21:42
@nyannyacha nyannyacha marked this pull request as ready for review November 4, 2025 23:13
@nyannyacha
Copy link
Contributor Author

nyannyacha commented Nov 5, 2025

Could you guide me on how to correctly reference usePackageJson within the Bundle method?
You linked https://github.com/supabase/cli/blob/develop/pkg/config/config.go#L324
But ultimately, to use it within the Bundle method, wouldn't we need to add a variadic argument after the arg list? Is that acceptable?

I just need to be able to reference it within the Bundle, and I'd appreciate it if you could let me know any way to do that. 🥹

@sweatybridge
Copy link
Contributor

But ultimately, to use it within the Bundle method, wouldn't we need to add a variadic argument after the arg list? Is that acceptable?

Yea kinda of. Because adding variadic args is backwards compatible.

Let me think about it a bit more too.

@sweatybridge sweatybridge merged commit 9f3ad13 into develop Nov 13, 2025
19 checks passed
@sweatybridge sweatybridge deleted the ny/add-use-pkg-json-flag branch November 13, 2025 08:54
@github-actions github-actions bot mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants