Fix two timing issues in delays.rs #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These changes correct the implementations of delays::SysTmr::wait_msec_st and delays::wait_msec to behave correctly and consistently with one another.
I believe this covers all copies of this bug in the codebase.
Member
| Awesome, thanks! 🙏 Could you add the two respective kernel8 binaries as well in the affected tutorials? |
Contributor Author
| I sure can. |
Member
| Thanks alot! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These changes correct the implementations of
delays::SysTmr::wait_msec_standdelays::wait_msecto behave correctly and consistently with one another.This resolves #7.