Skip to content

Migrate to React@16.3 for Context API #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
Aug 4, 2018
Merged

Migrate to React@16.3 for Context API #333

merged 55 commits into from
Aug 4, 2018

Conversation

@AllenFang
Copy link
Member

@AllenFang AllenFang commented May 13, 2018 •
edited
Loading

  1. No internal store anymore, more props driven and stateless for low level component
  2. Improve data flows
  3. Implement table toolkits: like search and csv export
@AllenFang AllenFang force-pushed the refactor/context-api branch 3 times, most recently from 2bf95d3 to f6508ff Compare May 20, 2018 07:52
@AllenFang AllenFang force-pushed the refactor/context-api branch from f9567cb to d99645d Compare May 20, 2018 08:36
chunming-c
chunming-c reviewed May 20, 2018
View reviewed changes
Copy link
Member

@chunming-c chunming-c left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I salute you sir 🎉🎉🎉
packages/react-bootstrap-table2/src/contexts/index.js Outdated
renderWithFilterCtx(base, baseProps) {
return (
rootProps,
cellEditprops
Copy link
Member

@chunming-c chunming-c May 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cellEditprops => cellEditProps
packages/react-bootstrap-table2/index.js Outdated

export default withDataStore(BootstrapTable);
export default withContext(BootstrapTable);

Copy link
Member

@chunming-c chunming-c May 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's extra empty line in ln. 8.
@AllenFang AllenFang force-pushed the refactor/context-api branch from f0a578f to 07c8b2c Compare May 20, 2018 10:20
@AllenFang
Copy link
Member Author

AllenFang commented May 20, 2018 •
edited
Loading

@Chun-MingChen Just do me a favor, please use create-react-app and use npm link to link react-bootstrap-table-next of this branch to test whether it can backward compatible with < react@16.3.0. This test will help me to decide peerDependency and it's may have a big impact for our user, thanks.

This task I want it to be done before I finish all the tests of this PR!!
@AllenFang AllenFang force-pushed the refactor/context-api branch 4 times, most recently from faead1d to 16bea7c Compare May 30, 2018 09:50
@chunming-c
Copy link
Member

chunming-c commented Jun 1, 2018

@AllenFang:

Sorry for reply late. I got it and I'll do it instantly.
@AllenFang AllenFang force-pushed the refactor/context-api branch 2 times, most recently from b6cbda0 to a0c592a Compare June 13, 2018 15:31
@AllenFang
Copy link
Member Author

AllenFang commented Jun 20, 2018

Also consider to handle #382 . this issue
@AllenFang AllenFang force-pushed the refactor/context-api branch from 041c881 to 7c8c008 Compare June 23, 2018 07:11
@AllenFang AllenFang force-pushed the refactor/context-api branch 3 times, most recently from be27825 to 7b411c8 Compare July 1, 2018 08:17
@AllenFang AllenFang force-pushed the refactor/context-api branch from d79234e to 1cc6e26 Compare July 14, 2018 08:27
@AllenFang
Copy link
Member Author

AllenFang commented Jul 14, 2018

#244
@AllenFang
Copy link
Member Author

AllenFang commented Jul 15, 2018

#332
@AllenFang AllenFang mentioned this pull request Jul 18, 2018
Closed
@AllenFang AllenFang changed the title [WIP] Migrate to React@16.3 for Context API Migrate to React@16.3 for Context API Jul 22, 2018
@AllenFang AllenFang force-pushed the refactor/context-api branch 2 times, most recently from 405120b to 046da7e Compare July 28, 2018 07:40
AllenFang added 26 commits August 1, 2018 20:26
@AllenFang
patch docs for table search
6eaffe1
@AllenFang
implement expand row sketch
35b1e37
@AllenFang
add stories for expand row
dbd0f89
@AllenFang
implement expand indicator
4af5b4f
@AllenFang
add stories for expand indicator
81ddd2c
@AllenFang
fix filter context tests broken due to missing onExternalFilter
c36aa24
@AllenFang
patch docs for expand row
a18932e
@AllenFang
add missing expandRow props
5a442bf
@AllenFang
data, keyField and columns is necessary value for toolkits context
e6d4a96
@AllenFang
add simple toolkit context wrapper for user
0ec5b6c
@AllenFang
refactoring search
03ece4b
@AllenFang
implement export csv
f0e37b1
@AllenFang
add export csv stories
b792803
@AllenFang
patch docs for export CSV
ec77a05
@AllenFang
a workaround for fixing the _ module missing
fadbcda
@AllenFang
enhance for #402
7919a40
@AllenFang
fix sort caret broken on bootstrap4
0d64443
@AllenFang
upgrade enzyme
f7ba8e3
@AllenFang
fix selection column broken when bootstrap4
c0416fc
@AllenFang
refine new context API tests
4958757
@AllenFang
fix pagination broken when bootstrap4
3f957db
@AllenFang
add bootstrap4 style links
62c6949
@AllenFang
final docs patch
925d3d7
@AllenFang
add toolkits styles
f7406bc
@AllenFang
patch for default sort and filter have potential issue when remote
2ec55f6
@AllenFang
fix React doesn't allow Date Object as children
d5d8c54
@AllenFang AllenFang force-pushed the refactor/context-api branch from c031859 to d5d8c54 Compare August 1, 2018 12:30
@AllenFang AllenFang merged commit a3ba464 into develop Aug 4, 2018
@AllenFang AllenFang deleted the refactor/context-api branch August 4, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical

4 participants

@AllenFang @chunming-c @justincorrigible