Skip to content

Optimized string column sort (comparator + splitNested) #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optimized string column sort (comparator + splitNested) #1627

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7abd060
Optimized splitNested
Avasam May 20, 2021
847df15
More efficient comparator for large array of string
Avasam May 20, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Optimized splitNested
  • Loading branch information
@Avasam
Avasam committed May 20, 2021
commit 7abd06033c7c38a56d13965494bc050f4dcb2458
8 changes: 3 additions & 5 deletions packages/react-bootstrap-table2/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@
import _ from 'underscore';

function splitNested(str) {
return [str]
.join('.')
.replace(/\[/g, '.')
.replace(/\]/g, '')
.split('.');
return str
.replace(']', '')
.split(/\[\./);
}

function contains(list, value) {
Expand Down