Skip to content

Fix PropertyExistsTypeSpecifyingExtension for union types #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Fix PropertyExistsTypeSpecifyingExtension for union types #4153

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
71071d4
add failing test
liamduckett Jul 23, 2025
7a2e77f
first stab at allowing constant string unions in narrowing calls to p…
liamduckett Jul 23, 2025
6487002
add new case - appear to have reintroduced 12778
liamduckett Jul 23, 2025
a7746f5
resolve reintroduced variant of 12778
liamduckett Jul 23, 2025
ecff9a1
change namespace for test
liamduckett Jul 23, 2025
4684f62
move empty string check, to satisfy static analysis
liamduckett Jul 24, 2025
e69e5f3
update baseline
liamduckett Jul 24, 2025
29a73c1
lint
liamduckett Jul 24, 2025
1f40e18
remove second test, as covered by static analysis
liamduckett Jul 24, 2025
40ba340
remove redundant check for object being a constant string
liamduckett Jul 24, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@liamduckett
liamduckett committed Jul 24, 2025
commit 29a73c11f08f8a7d00c0ff9e19f58ff4b43886d3
16 changes: 9 additions & 7 deletions src/Type/Php/PropertyExistsTypeSpecifyingExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ public function specifyTypes(
} elseif ($objectType->isObject()->yes()) {
$propertyNodes = [];

foreach($propertyNameTypes as $propertyNameType) {
if($propertyNameType->getValue() === '') {
foreach ($propertyNameTypes as $propertyNameType) {
if ($propertyNameType->getValue() === '') {
return new SpecifiedTypes([], []);
}

Expand All @@ -91,12 +91,14 @@ public function specifyTypes(
return new SpecifiedTypes([], []);
}

foreach($propertyNodes as $propertyNode) {
foreach ($propertyNodes as $propertyNode) {
$propertyReflection = $this->propertyReflectionFinder->findPropertyReflectionFromNode($propertyNode, $scope);
if ($propertyReflection !== null) {
if (!$propertyReflection->isNative()) {
return new SpecifiedTypes([], []);
}
if ($propertyReflection === null) {
continue;
}

if (!$propertyReflection->isNative()) {
return new SpecifiedTypes([], []);
}
}

Expand Down