Skip to content

Conversation

@jasonbarry
Copy link
Contributor

@jasonbarry jasonbarry commented Jul 13, 2022

Summary

Fixes https://github.com/netlify/pillar-workflow/issues/719

This PR renames the env:migrate command with env:clone. Since environment variables get copied (rather than moved) from Site A to Site B, we've decided to rename the command. migrate has been added as an alias of clone, so this is a non-breaking change.

Some prior history on the command naming: #3876 (review)


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Screenshot 2022-07-12 at 17 36 41

@jasonbarry jasonbarry self-assigned this Jul 13, 2022
@jasonbarry jasonbarry added the type: chore work needed to keep the product and development running smoothly label Jul 13, 2022
@github-actions
Copy link

github-actions bot commented Jul 13, 2022

📊 Benchmark results

Comparing with f266c7a

Package size: 227 MB

⬆️ 0.01% increase vs. f266c7a

^ 227 MB 227 MB 227 MB 227 MB 227 MB 227 MB 227 MB 227 MB 227 MB 227 MB 227 MB 227 MB 227 MB │ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| └───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──> T-12 T-11 T-10 T-9 T-8 T-7 T-6 T-5 T-4 T-3 T-2 T-1 T 
Legend
@jasonbarry jasonbarry marked this pull request as ready for review July 13, 2022 00:38
@jasonbarry jasonbarry requested a review from a team as a code owner July 13, 2022 00:38
@jasonbarry jasonbarry changed the title chore: rename env:migrate to env:clone chore: rename env:migrate to env:clone Jul 13, 2022
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eduardoboucas
Copy link
Member

You might want to rename this to feat: when squashing though, since chore: commits don't trigger a release.

@jasonbarry
Copy link
Contributor Author

No rush on this one @eduardoboucas! I'm cool with it being lumped into the next release.

@jasonbarry jasonbarry added the automerge Add to Kodiak auto merge queue label Jul 13, 2022
@eduardoboucas
Copy link
Member

eduardoboucas commented Jul 13, 2022

No rush on this one @eduardoboucas! I'm cool with it being lumped into the next release.

I still think we should prefix it properly, because it does add new functionality and a chore: doesn't reflect that. This will show in the changelog.

You can use feat: and still just wait for something else to be released.

@jasonbarry jasonbarry removed the automerge Add to Kodiak auto merge queue label Jul 13, 2022
@kodiakhq kodiakhq bot merged commit 3449edf into main Jul 13, 2022
@kodiakhq kodiakhq bot deleted the chore/rename-migrate-to-clone branch July 13, 2022 15:57
@jasonbarry
Copy link
Contributor Author

Shoot, just missed it -- can it be changed retroactively?

@eduardoboucas
Copy link
Member

I'm not sure! 🤔 But it's not a big deal, don't worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore work needed to keep the product and development running smoothly

2 participants