Fix rpm-package-build task #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* add simple `Version` class * add self test of version sorting * revise self-test comment * update version in self-test This is a slightly modified cherry-pick of: mongodb/mongo-c-driver@2bf9d59
Contributor Author
| Also, I'd like to cherry-pick this to |
Collaborator
| The patch attached to the PR failed: Is that expected to be resolved after merging? |
Contributor Author
| I am actually not sure why it succeeded in my manual patch build but is failing now in the triggered patch build. I'm trying to see if I can work out the precise cause. |
Contributor Author
| @kevinAlbs I'm still not entirely sure why it failed, because I would have expected it to be only about the version number in the spec file, but I also had to adjust the dependencies as well. Either way, it's ready for review now. |
kevinAlbs approved these changes Jan 8, 2024
rcsanchez97 added a commit that referenced this pull request Jan 9, 2024
* use Fedora 40 for rpm-package-build task * update RPM spec patch * A slightly modified cherry-pick of: mongodb/mongo-c-driver@2bf9d59 - Define `Version` in `calc_release_version.py` - add simple `Version` class - add self test of version sorting - revise self-test comment - update version in self-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Task-specific Evergreen patch build: https://spruce.mongodb.com/version/65986bbec9ec44bb3305b63b/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
@kevinAlbs I am requesting your review on this since the biggest change here is a modified cherry-pick of this commit that you authored.