Skip to content

Two #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 28, 2019
Merged

Two #30

merged 5 commits into from
Dec 28, 2019

Conversation

@keller-mark
Copy link
Owner

@keller-mark keller-mark commented Dec 28, 2019

  • Render to both canvas and svg using same plotting code by drawing to two.js scene rather than directly to canvas or svg
    • Allows rendering to canvas in browser but downloading to SVG
    • Hopefully only small hit to performance and library size
  • Update downloading code in PlotContainer component
  • Fix download limit bug by using JavaScript Blob object URLs rather than data URI strings
  • Add download buttons to all plots on demo site
@coveralls
Copy link

coveralls commented Dec 28, 2019

Pull Request Test Coverage Report for Build 295

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.738%
Totals Coverage Status
Change from base Build 288: 0.0%
Covered Lines: 183
Relevant Lines: 391
💛 - Coveralls
@keller-mark keller-mark merged commit 6947b8d into master Dec 28, 2019
@keller-mark keller-mark deleted the two branch January 25, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@keller-mark @coveralls