chore(python): Add support for Python 3.14 #644
Conversation
product-auto-label bot added size: xs 
product-auto-label bot added size: s 
chalmerlowe added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run chalmerlowe added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run chalmerlowe added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run product-auto-label bot added size: m 
| env_vars: { | ||
| key: "NOX_SESSION" | ||
| value: "system-3.8" | ||
| value: "system-3.12" |
There was a problem hiding this comment.
| value: "system-3.12" | |
| value: "system-3.14" |
| [mypy-google.cloud.datastore_v1.services.datastore.async_client] | ||
| ignore_errors = True | ||
| | ||
| [mypy-google.cloud.datastore_v1.services.datastore.client] | ||
| ignore_errors = True |
There was a problem hiding this comment.
Can we pin mypy instead of ignoring the errors, with a bug to follow up on removing the pin for mypy?
There was a problem hiding this comment.
Either / or should be fine? I see that firestore is also ignoring error. Both workarounds require us to fix the issue upsteam.
There was a problem hiding this comment.
Ack. We will need a bug to follow up on removing this code in mypy.ini
| | ||
| # Ensure Python 3.14 is in the skip list for cpp proto implementation | ||
| s.replace( | ||
| "noxfile.py", |
There was a problem hiding this comment.
Is this needed? noxfile.py is no longer part of synthtool templates
| s.replace( | ||
| ".github/workflows/mypy.yml", | ||
| r'''python-version: "3.8"''', | ||
| '''python-version: "3.10"''', |
There was a problem hiding this comment.
Is this needed? The file doesn't exist in templates : https://github.com/googleapis/synthtool/tree/master/synthtool/gcp/templates/python_library/.github/workflows
| return ga_credentials_async.AnonymousCredentials() | ||
| return ga_credentials.AnonymousCredentials() | ||
| else: # pragma: NO COVER | ||
| return ga_credentials.AnonymousCredentials() |
There was a problem hiding this comment.
Is this file autogenerated? If so, this will be removed in the next generation PR. https://github.com/googleapis/googleapis-gen/blob/master/google/datastore/admin/v1/datastore-admin-v1-py/tests/unit/gapic/datastore_admin_v1/test_datastore_admin.py
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
…python-datastore into feat/add-python-3.14
…python-datastore into feat/add-python-3.14
…python-datastore into feat/add-python-3.14
This PR adds support for Python 3.14 to the library.
Key changes include:
.github/workflowsfiles to account for Python runtimes both 3.14 and 3.8..github/workflows/unittest.yml, etc..github/sync-repo-settings.yamlto include 3.14 unit tests in required checks..kokoro/presubmitfiles to update the system test andpresubmit.cfgtesting/constraints-3.14.txt.CONTRIBUTING.rstto list Python 3.14 as a supported version.mypy.inito suppress several known type hinting errors in two files.noxfile.pyto include 3.14 sessions.owlbot.pyto include Python 3.14.setup.pyto include the Python 3.14 classifier and add conditional dependencies forgrpcio.