[Bugfix] Remove finalizer from Gateway #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the automatic enforcement of finalizers on Gateway pods. Key changes include:
- Deletion of the
EnsureFinalizerPresentblock and relatedgroupSpecvariable inpod_inspector.go - Addition of a new bugfix entry in
CHANGELOG.md
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/deployment/resources/pod_inspector.go | Remove finalizer restoration logic and unused groupSpec |
| CHANGELOG.md | Document “Remove Finalizer from Gateway” bugfix |
Comments suppressed due to low confidence (2)
pkg/deployment/resources/pod_inspector.go:108
- Consider adding or updating unit/integration tests to verify that finalizers are no longer enforced on Gateway pods, ensuring the removal behaves as expected.
spec := r.context.GetSpec() CHANGELOG.md:14
- Ensure this changelog entry is placed under the correct unreleased or upcoming version heading to maintain consistency with project conventions.
- (Bugfix) Remove Finalizer from Gateway Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.