Docs: Formatting #240
Merged
Docs: Formatting #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
maxkernbach approved these changes Dec 5, 2018
Contributor
maxkernbach left a comment
maxkernbach left a comment There was a problem hiding this comment.
LGTM
Did you use a script to format the text/code sections?
Contributor Author
| @maxkernbach: No, I tried to re-format something with a regex, but it didn't work as expected in vscode. I ended up doing it manually and case by case (I checked the current online version to see where code examples were too wide = scrollbars and fixed these) |
sleto-it approved these changes Dec 5, 2018
Contributor
sleto-it left a comment
sleto-it left a comment There was a problem hiding this comment.
Please do NOT change any code in a doc PR unless strictly strictly needed (it was not in this case). Rather open different PR with the code changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.