Skip to content

chore: remove the use of IntValueRange #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2025
Merged

chore: remove the use of IntValueRange #942

merged 1 commit into from
Nov 8, 2025
+10 −14

Conversation

@zepfred
Copy link
Contributor

@zepfred zepfred commented Nov 4, 2025

Description of the change

Companion for TimefoldAI/timefold-solver#1900

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.
triceo
triceo requested changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing.
@zepfred
Copy link
Contributor Author

zepfred commented Nov 4, 2025

CI is failing.

I haven't pushed the solver changes yet and will convert it to draft.
@zepfred zepfred marked this pull request as draft November 4, 2025 20:13
@zepfred zepfred marked this pull request as ready for review November 5, 2025 19:40
@zepfred zepfred changed the title chore: remove the use of `IntValueRange chore: remove the use of IntValueRange Nov 7, 2025
triceo
triceo approved these changes Nov 8, 2025
View reviewed changes
Copy link
Collaborator

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified working with latest main.
@triceo triceo merged commit 2dde23f into TimefoldAI:development Nov 8, 2025
58 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@zepfred @triceo