fix: use typescript from @schematics/angular #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sis0k0 approved these changes Aug 19, 2019
Contributor
sis0k0 left a comment
sis0k0 left a comment There was a problem hiding this comment.
Looks great! Should we also remove the devDependency to TypeScript?
Contributor Author
| Tried removing the |
sis0k0 changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
@nativescript/schematicspackage uses TypeScript utility functions from@schematics/angular. The utility functions return ASTs generated from the source code. After that these ASTs are used by other functions in@nativescript/schematics.@nativescript/schematicsdepends on the version of TypeScript used in the project, whereas@schematics/angularembeds its own version oftypescript. If the versions of the two TypeScript packages don't match, we end up comparing ASTs generated from different TS versions which usually results in an error. Currently, we rely on the assumption that the project will have matching versions of@schematics/angularandTypeScript.With this PR, the code using utilities from
@schematics/angularnow importstypescriptfrom@schematics/angularguaranteeing the same instance of the TypeScript library will be used.