fix: make @schematics/angular a devDependency and update to Angular 8.2 #237
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
@nativescript/schematicspackage uses TypeScript utility functions from@schematics/angular. The utility functions return ASTs generated from the source code. After that these ASTs are used by other functions in@nativescript/schematics.@nativescript/schematicsdepends on the version of TypeScript used in the project, whereas@schematics/angularhas its own dependency on TypeScript. If the versions of the two TypeScript packages don't match, we end up comparing ASTs generated from different TS versions which usually results in an error.This PR removes the dependency of
@schematics/angularfrom the@nativescript/schematics. That way, the version in the user's project will be used instead. We rely on the assumption that the project will have matching versions of@schematics/angularand TypeScript.