refactor: update to NativeScript 6.0 #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
{N} 6.0 uses only webpack for building. When building Angular apps with Webpack,the `module.id` is inserted automatically and we don't need to set it manually. There's even a loader in `nativescript-dev-webpack` which removes the moduleIds from the source code. In short, the `moduleId: module.id` is useful only for builds without webpack. NativeScript 6.0 doesn't support such builds. That's why we don't need moduleId in the templates anymore. 
dtopuzov added a commit to NativeScript/nativescript-tooling-qa that referenced this pull request Jul 26, 2019
Address changes introduced by NativeScript/nativescript-schematics#220
dtopuzov added a commit to NativeScript/nativescript-tooling-qa that referenced this pull request Jul 26, 2019
Address changes introduced by NativeScript/nativescript-schematics#220
dtopuzov added a commit to NativeScript/nativescript-tooling-qa that referenced this pull request Jul 26, 2019
Adress changes introduced by NativeScript/nativescript-schematics#220
dtopuzov added a commit to NativeScript/nativescript-tooling-qa that referenced this pull request Jul 26, 2019
* fix: schematics tests Adress changes introduced by NativeScript/nativescript-schematics#220 * chore: add docs string in tests * fix: install schematics as dev dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
refactor: bump template versions to {N} 6.0
refactor: set
markingModetononerefactor: remove
moduleIdfrom component metadata{N} 6.0 uses only webpack for building. When building Angular apps with
Webpack,the
module.idis inserted automatically and we don't need toset it manually. There's even a loader in
nativescript-dev-webpackwhich removes the moduleIds from the source code.In short, the
moduleId: module.idis useful only for builds without webpack. NativeScript 6.0 doesn't support such builds. That's why we don't need moduleId in the templates anymore.