Skip to content

Conversation

@sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Jun 19, 2019

PR Checklist

What is the current behavior?

NativeScript Schematics doesn't work with Angular 8.0.

What is the new behavior?

NativeScript Schematics works with Angular 8.0.

@cla-bot cla-bot bot added the cla: yes label Jun 19, 2019
@sis0k0 sis0k0 changed the title Sis0k0/ng 8 feat: update to Angular 8.0 Jun 19, 2019
@sis0k0 sis0k0 marked this pull request as ready for review June 19, 2019 07:08
Copy link
Contributor

@vakrilov vakrilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sis0k0 sis0k0 merged commit 0837158 into master Jun 21, 2019
@sis0k0 sis0k0 deleted the sis0k0/ng-8 branch June 21, 2019 11:13
dtopuzov added a commit to NativeScript/nativescript-tooling-qa that referenced this pull request Jun 21, 2019
NativeScript/nativescript-schematics#214 require global installation of NG CLI. Since we do not rely heavily on NG CLI I suggest insalling it globally. If we encounter troubles we may try local install and custom NPM prefix.
dtopuzov added a commit to NativeScript/nativescript-tooling-qa that referenced this pull request Jun 21, 2019
dtopuzov added a commit to NativeScript/nativescript-tooling-qa that referenced this pull request Jun 25, 2019
* fix: install NG CLI globally NativeScript/nativescript-schematics#214 require global installation of NG CLI. Since we do not rely heavily on NG CLI I suggest insalling it globally. If we encounter troubles we may try local install and custom NPM prefix. * fix: console log messages - Update console log messages. - Install @nativescript/schematics globaly * chore: ignore ng serve --prod Known issue caused by NativeScript/nativescript-schematics#214 * chore: fix app size value * chore: remove tests without bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants