Skip to content

Conversation

@goergisn
Copy link
Contributor

Summary

  • Fixes following scenario:
    • Protocols that get extended with default implementations that have an access level defined would show both in their public diff

Example

public protocol ProtocolWithDefaultImplementation { func function() -> String } extension ProtocolWithDefaultImplementation { public func function() -> String { return "" } } 
@github-actions
Copy link

✅ No changes detected

Comparing fix-extension-duplicates to main


Analyzed targets: FileHandlingModule, PADCore, PADLogging, PADOutputGenerator, PADPackageFileAnalyzer, PADProjectBuilder, PADSwiftInterfaceDiff, PADSwiftInterfaceFileLocator, ShellModule, SwiftPackageFileHelperModule

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.6% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

@goergisn goergisn merged commit a74d7dc into main Apr 10, 2025
2 of 3 checks passed
@goergisn goergisn deleted the fix-extension-duplicates branch April 10, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants