[Gecko Bug 2006366] Adjust WPT anchor-parse-valid.html to accept simplification of min(x%, y%) function within anchor(). #56876
+13 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…, y%) function within anchor(). Min() or max() functions used in anchor() can be simplified, given that the percentage basis is a size that cannot be negative. In such cases, Firefox does the simplification, so that min(50%, 100%) gets serialized as calc(50%). This just modifies the test to expect either the originally-specified or the simplified form in the affected cases. (See also w3c/csswg-drafts#12131.) Differential Revision: https://phabricator.services.mozilla.com/D277113 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2006366 gecko-commit: a192fac33d879e7e44591f739c5f801902c6e994 gecko-reviewers: layout-reviewers, layout-anchor-positioning-reviewers, dshin, dholbert
wpt-pr-bot approved these changes Dec 19, 2025
Collaborator
wpt-pr-bot left a comment
wpt-pr-bot left a comment There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Min() or max() functions used in anchor() can be simplified, given that the
percentage basis is a size that cannot be negative.
In such cases, Firefox does the simplification, so that min(50%, 100%) gets
serialized as calc(50%).
This just modifies the test to expect either the originally-specified or the
simplified form in the affected cases.
(See also w3c/csswg-drafts#12131.)
Differential Revision: https://phabricator.services.mozilla.com/D277113
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2006366
gecko-commit: a192fac33d879e7e44591f739c5f801902c6e994
gecko-reviewers: layout-reviewers, layout-anchor-positioning-reviewers, dshin, dholbert