Skip to content

Conversation

@thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Dec 21, 2021

Description

This updates our test suite and the project’s metadata. Python 3.6’s support ends in 3 days. Python 3.10 has been out for a few months now and we need this package to support it.

The main difficulty here was getting Poetry to cooperate – they had a lot of Python 3.10 compatibility issues, and the JSONDecodeError fix from the latest v1.1.12 was required.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

Suggested CHANGELOG entry:

### Added - This package now supports Python 3.10 ([#163](https://github.com/torchbox/django-pattern-library/pull/163). ### Removed - We no longer support Python 3.6, as it has reached its end of life ([#163](https://github.com/torchbox/django-pattern-library/pull/163).
@thibaudcolas thibaudcolas added enhancement New feature or request django Related to Django templates capabilities status: Needs review labels Dec 21, 2021
@thibaudcolas thibaudcolas mentioned this pull request Dec 21, 2021
8 tasks
@thibaudcolas thibaudcolas force-pushed the chore/python-versions branch 4 times, most recently from d941195 to 760dad6 Compare December 21, 2021 21:08
@thibaudcolas thibaudcolas marked this pull request as ready for review December 21, 2021 23:17
toxenv: py39-dj22,py39-dj30,py39-dj31,py39-dj32,py39-djmain
toxenv: py39-dj22,py39-dj30,py39-dj31,py39-dj32
- python: "3.10"
toxenv: py310-dj32,py310-djmain
Copy link
Member Author

@thibaudcolas thibaudcolas Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things worth mentioning here:

  • I thought it would be enough to only test djmain with the most recent Python version
  • Similarly since py31-dj32 is already tested in the previous test job, I’ve removed it here.
@thibaudcolas thibaudcolas added this to the v1.0.0 milestone Jan 19, 2022
@thibaudcolas thibaudcolas merged commit 107b2c3 into main Jan 24, 2022
@thibaudcolas thibaudcolas deleted the chore/python-versions branch January 24, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

django Related to Django templates capabilities enhancement New feature or request

2 participants