Add X_FRAME_OPTIONS to install instructions #128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I'm not sure that advising a project to set this globally because it includes this app is the right thing to do. We're already setting this header explicitly on responses to GET requests to the Is there some circumstance under which that doesn't work? |
Author
| I can't reproduce my setup. DPL works fine. My bad. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the readme to set
X_FRAME_OPTIONS = 'SAMEORIGIN'on Django 3.0 and up.This is because Django switched from 'SAMEORIGIN' to 'DENY' as default.
https://docs.djangoproject.com/en/3.1/releases/3.0/#security
Checklist
✅ My code follows the style guidelines of this project
✅ I have performed a self-review of my own code
N/A I have commented my code, particularly in hard-to-understand areas
✅ I have made corresponding changes to the documentation
N/A My changes generate no new warnings
N/A I have added tests that prove my fix is effective or that my feature works
✅ New and existing unit tests pass locally with my changes