angular: document deferrable views #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MatanBobi reviewed Jan 5, 2024
| ```typescript | ||
| const {rerender} = await render(Counter, { | ||
| componentProperties: {count: 4, name: 'Sarah'}, | ||
| componentInputs: {count: 4, name: 'Sarah'}, |
There was a problem hiding this comment.
Is there an implementation of the Counter component somewhere in this page? I wasn't able to find it. Maybe it will help to add it?
There was a problem hiding this comment.
No, the implementation is "hidden" inside of the ATL repo.
I'll leave this for now. This comment makes me think if I should add a link to a working example (most of these already exist within ATL).
What's your opinion?
There was a problem hiding this comment.
For the Counter component? Isn't it just for the example? I think it might help to have it here but if the component is big then a link might also work.
MatanBobi reviewed Jan 5, 2024
timdeschryver commented Jan 5, 2024
MatanBobi approved these changes Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for a new API introduced in ATL.