Skip to content

Conversation

OkuyanBoga
Copy link

A solution to potential data leakage in #828.

Instead of concatenating train and test sets, they should be separately dealt with when getting a stilted dataset:

In lines L745-752:

y_train_new = get_stilted_dataset(S_pqk, V_pqk, S_original, V_original) y_test_new = get_stilted_dataset(S_pqk_test, V_pqk_test, S_test_original, V_test_original) 

where spectrum is calculated separately for test set:

S_pqk_test, V_pqk_test = get_spectrum( tf.reshape(x_test_pqk, [-1, len(qubits) * 3])) S_test_original, V_test_original = get_spectrum( tf.cast(x_test, tf.float32), gamma=0.005) print('Eigenvectors of pqk kernel matrix for test:', V_pqk_test) print('Eigenvectors of original kernel matrix for test:', V_test_original) 

Closes #828.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant