Fix bug in selectionChange event when selecting objects using ctrl-click (command click on mac). #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When selecting multiple items using ctrl-click, the selectionChange event emits an event where the oldValue array has 0 items and newValue array has 1 item when selecting the first item. But when selecting the second item, the oldValue array incorrectly has 0 items and newValue incorrectly has 1 item. The expected behavior is that on the second ctrl-selection, the oldValue has 1 item and newValue has 2 items.
| Hi Nick Anderson, We have logged this as defect. The fix for the reported issue will be available end of august 2019. Regards, |
| Hi Nick Anderson, We are glad to announce that our patch release (v17.2.41) is rolled out successfully and In that release, we have added the fix for reported issue. Please upgrade to the latest version packages to resolve this issue. Regards, |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When selecting multiple items using ctrl-click, the selectionChange event emits an event where the oldValue array has 0 items and newValue array has 1 item when selecting the first item.
But when selecting the second item, the oldValue array incorrectly has 0 items and newValue incorrectly has 1 item. The expected behavior is that on the second ctrl-selection, the oldValue has 1 item and newValue has 2 items.
NOTE: I unfortunately was not able to get either
npm run buildornpm testworking locally to verify that the fix worked. If y'all have any guidance there, that would be much appreciated :)