Skip to content

replace static insert-css calls with null #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2016
Merged

replace static insert-css calls with null #6

merged 1 commit into from
Jul 29, 2016

Conversation

@ahdinosaur
Copy link
Member

@ahdinosaur ahdinosaur commented Jun 21, 2016

apparently they were being left as is?

motivation is to fix stackcss/sheetify#77, as in that case we're already using css-extract but the insert-css calls remain.
@ahdinosaur ahdinosaur mentioned this pull request Jun 21, 2016
Closed
@codecov-io
Copy link

codecov-io commented Jun 21, 2016 •
edited
Loading

Current coverage is 100%

No coverage report found for master at 19383b7.

Powered by Codecov. Last updated by 19383b7...2d50b97
@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Jun 21, 2016

oh interesting! I reckon you tested this? If it works, go for it! :D
@marionebl marionebl mentioned this pull request Jul 27, 2016
Closed
@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Jul 29, 2016

Let's merge this! 😁
@yoshuawuyts yoshuawuyts merged commit 3fa5d85 into master Jul 29, 2016
@yoshuawuyts yoshuawuyts deleted the remove-static-insert-css-calls branch July 29, 2016 15:27
@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Jul 29, 2016

Released as v1.1.1 🎉
@ahdinosaur ahdinosaur mentioned this pull request Aug 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@ahdinosaur @codecov-io @yoshuawuyts