Add toString() method in ArgumentValue #1196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
spring-projects-issues added the status: waiting-for-triage 
rstoyanchev added type: enhancement rstoyanchev changed the title 
rstoyanchev approved these changes Apr 23, 2025
There was a problem hiding this comment.
@SnuK87 the change is good, but if you could, please check the DCO requirements, and follow the instructions to sign off the commit
Signed-off-by: Dennis Griese <d.griese1987@gmail.com>
SnuK87 force-pushed the argumentvalue-tostring branch from 63e6fc3 to 741a3a5 Compare 
| @rstoyanchev Thanks for the fast feedback. Updated the Commit as described in the instructions. |
rstoyanchev added the for: backport-to-1.3.x rstoyanchev added status: backported rstoyanchev pushed a commit that referenced this pull request May 29, 2025
See gh-1196 Signed-off-by: Dennis Griese <d.griese1987@gmail.com>
rstoyanchev added a commit that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Override
toString()method inArgumentValueclass based upon thejava.util.Optionalimplementation.Purpose:
The
ArgumentValueclass doesn't overridetoString()which makes logging and debugging quite tedious.For example, if you define an input type for a graphql mutation with multiple properties wrapped in
ArgumentValue:You would have to manually write a custom
toString()method forMyInputbecause IDEs or Lombok are (afaik) not able to generate it properly.