Skip to content

Conversation

JBodkin-Amphora
Copy link

No description provided.

Signed-off-by: James Bodkin <james.bodkin@amphora.net>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 3, 2025
@bclozel bclozel self-assigned this Apr 3, 2025
@bclozel bclozel added type: enhancement A general enhancement in: data Issues related to working with data and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 3, 2025
@bclozel bclozel added this to the 1.4.0-RC1 milestone Apr 3, 2025
@bclozel
Copy link
Member

bclozel commented Apr 3, 2025

See #1174 for background.

@bclozel bclozel changed the title Add Jackson module to serialize/deserialize ArgumentValue Add Jackson module to serialize/deserialize FieldValue Apr 15, 2025
bclozel added a commit that referenced this pull request Apr 15, 2025
Prior to this commit, `ArgumentValue<T>` would mainly focus on the server-side support with the binding of arguments on Controller methods. With the introduction of this feature on the client in gh-1174, this commit reconsiders both the `ArgumentValue<T>` name and its package location to reflect the broader support. This commit deprecates `ArgumentValue<T>` in favor of `FieldValue<T>` with similar support. Closes gh-1187
@bclozel bclozel closed this in 1ec45c6 Apr 15, 2025
bclozel added a commit that referenced this pull request Apr 15, 2025
The various GraphQL clients supported in this project automatically detect JSON codecs for reading/writing GraphQL requests as JSON payloads. If there is none detected, clients provide a default codec instance. This commit configures automatically the `GraphQlModule` from gh-1174 in default codecs and add integration tests for `FieldValue<T>` usage on the client side. This also improves the documentation around `FieldValue<T>` for both server and client side support. Closes gh-1190
bclozel added a commit that referenced this pull request Apr 15, 2025
@bclozel bclozel added the status: declined A suggestion or change that we don't feel we should currently apply label Apr 15, 2025
@bclozel bclozel removed this from the 1.4.0-RC1 milestone Apr 15, 2025
@bclozel
Copy link
Member

bclozel commented Apr 18, 2025

This has been reverted in favor of exploring alternatives with #569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: data Issues related to working with data status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

3 participants