Reinstate tags-as-metadata adding option to merge tags. Fixes #699 #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Author
| @spencergibb @ryanjbaxter could you guys have a look? Adding this backwards compatibility would help to upgrade Spring Boot in large enterprise deployments and, for example, cleanly remediate recently popular CVE-2022-22965. Thanks! |
| Any progress here? @spencergibb I will close #700 in favor of this one. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Picking up the work from #700
I've brought back the missing constructor as mentioned in the review comments of PR 700. Additionally I've added support to start reading isSecure from tags when enabled - for full backwards compatibility.
I did not address the comments around ConfigServer - I see this PR as a compatibility bridge for services already deployed with older versions of Spring Boot, I see current scope of changes sufficient to achieve this goal?
Please be gentle, my first contribution to Spring.