Circular buffer fixes #194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…it_sz is not a power of two
…o size It was not obvious how to make this implementation work when the unit size was not also a power of two, so for now just make the buffer size a multiple of the unit size so it can pass all the tests.
Contributor
| Thanks! Integrated. In the future, it's nice to at least make sure the testsuite passes at each commit-point, just to make bisecting easier. I did not check each of these to be sure of that, but it's a good guideline. |
oli-obk added a commit to oli-obk/rust that referenced this pull request Jul 19, 2017
Enable a test that was accidentally left disabled
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this pull request Dec 12, 2017
…quashed Fixed for DragonFly
ZuseZ4 referenced this pull request in EnzymeAD/rust Mar 7, 2023
* implemented forward mode visitCastInst
celinval pushed a commit to celinval/rust-dev that referenced this pull request Dec 6, 2024
Towards rust-lang#150 ### Changes * Added a harness for `is_empty` * Added a small optimization for `arbitray_cstr` ### Verification Result ``` SUMMARY: ** 0 of 193 failed (5 unreachable) VERIFICATION:- SUCCESSFUL Verification Time: 51.462265s Complete - 1 successfully verified harnesses, 0 failures, 1 total. ```
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This branch adds more tests for the circular buffer runtime class, and makes it work correctly for items that do not have a power of two size. It does this by completely removing the assumption that the buffer is sized to a power of two. I can't say what affect this change has on performance but I figure that's not too important right now.
Some of the intermediate commits are not correct, but they do reflect how I did the work. I can roll them up into a single commit if you want.