Simple imports #193
Closed
Simple imports #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…grams. This is likely not the final solution. It does repetitive work and doesn't produce errors for invalid but unused imports. In any case, I think it is a useful step.
Contributor
| Merged last week |
oli-obk added a commit to oli-obk/rust that referenced this pull request Jul 19, 2017
Rustup 1.4 fixed the permissions of the extracted files
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this pull request Dec 12, 2017
Fix iOS builds
dlrobertson pushed a commit to dlrobertson/rust that referenced this pull request Nov 29, 2018
Fix type typo in tokens.md.
ZuseZ4 referenced this pull request in EnzymeAD/rust Mar 7, 2023
* added getForwardBuilder * storeInst forward mode * loadInst forward mod * moved forward and reverse builder helpers into GradientUtils
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Mar 7, 2023
Parallelize CI
celinval pushed a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
* Replace slower lookup by pretty name with symbol name * Add nonnull fn call assertion (with new utility fn) * Kill pretty_name_from_instance * Remove fixme from boxmuttrait test that now works * Pipe pretty_name through Symbol::function constructor * Don't pass non-specific pretty names
carolynzech pushed a commit to celinval/rust-dev that referenced this pull request Dec 13, 2024
Towards rust-lang#150 Similar PR Ref : rust-lang#193 Annotates and verifies the safety contracts for the unsafe function : `from_ptr` - `core::ffi::c_str` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Yenyun035 <57857379+Yenyun035@users.noreply.github.com> Co-authored-by: Yenyun035 <yew005eng@gmail.com>
carolynzech pushed a commit to celinval/rust-dev that referenced this pull request Dec 13, 2024
…ith_nul_unchecked (rust-lang#193) Towards rust-lang#150 Annotates and verifies the safety contracts for the following unsafe functions: `from_bytes_with_nul_uncheked` `core::ffi::c_str` `strlen` `core::ffi::c_str` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Yenyun035 <yew005eng@gmail.com> Co-authored-by: Yenyun035 <57857379+Yenyun035@users.noreply.github.com> Co-authored-by: Carolyn Zech <cmzech@amazon.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is incomplete, but lets us compile simple cases. The basic idea is that nothing 'really' resolves to an import, we return what the import points to.
The final implementation will probably use a import -> def table that is constructed in fold_view_import. This will avoid repetitive work and will be a convenient place for producing errors about incorrect but unused imports.