add a test for combining RPIT with explicit tail calls #148846
Merged
+32 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added S-waiting-on-review 
Collaborator
|
|
WaffleLapkin approved these changes Nov 12, 2025
Member
| @bors r+ rollup |
Collaborator
bors added S-waiting-on-bors 
bors added a commit that referenced this pull request Nov 13, 2025
Rollup of 7 pull requests Successful merges: - #147701 (rustdoc: don't ignore path distance for doc aliases) - #148735 (Fix ICE caused by invalid spans for shrink_file) - #148839 (fix rtsan_nonblocking_async lint closure ICE) - #148846 (add a test for combining RPIT with explicit tail calls) - #148872 (fix: Do not ICE when missing match arm with ill-formed subty is met) - #148880 (Remove explicit install of `eslint` inside of `tidy`'s Dockerfile) - #148883 (bootstrap: dont require cmake if local-rebuild is enabled) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit that referenced this pull request Nov 13, 2025
Rollup merge of #148846 - folkertdev:tail-call-rpit, r=WaffleLapkin add a test for combining RPIT with explicit tail calls tracking issue: #112788 fixes #139305 Combining return position impl trait (RPIT) with guaranteed tail calls does not currently work, but at least it does not ICE any more. Using RPIT probably should work, see also #144953. The snippet in the issue is not valid for a variety of reasons, and based on the assert that got triggered the ICE was just any `-> impl Trait` at all, so I've made a minimal example using RPIT. r? `@WaffleLapkin`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
tracking issue: #112788
fixes #139305
Combining return position impl trait (RPIT) with guaranteed tail calls does not currently work, but at least it does not ICE any more.
Using RPIT probably should work, see also #144953.
The snippet in the issue is not valid for a variety of reasons, and based on the assert that got triggered the ICE was just any
-> impl Traitat all, so I've made a minimal example using RPIT.r? @WaffleLapkin