std: reorganize the UNIX-internal weak
module #146629
Open
+232 −270
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This moves the
dlsym
-based and weak-linkage versions of theweak!
macro into separate files, both of which include a common test file. As a result, both versions will be tested on all the platforms where they are used.Since the
#[link_name]
arm of thedlsym
version was unused, I've removed it. I've also removed the unusedraw_syscall!
and non-Linuxsyscall!
macros and gated the#[allow(dead_code, unused_macros)]
to only apply on non-Linux platforms, so compilation will fail ifweak
turns out to be unused on all platforms.The last change concerns the use of
dlsym!
on FreeBSD: it is only used once, to link againstsysctlbyname
. But that symbol is always available, so there is no need for weak linkage.