Update kn service command for the scale-min configuration #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The kn command for the service should be a `create` one instead of an `update` one as we require the reader to delete the resource in the preceding section. Either we have to remove that sentence of removal or we should use another `create` in there.
ammbra approved these changes Mar 16, 2022
github-actions bot pushed a commit that referenced this pull request Mar 16, 2022
The kn command for the service should be a `create` one instead of an `update` one as we require the reader to delete the resource in the preceding section. Either we have to remove that sentence of removal or we should use another `create` in there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The kn command for the service should be a
createone instead of anupdateone as we require the reader to delete the resource in the preceding section (https://redhat-developer-demos.github.io/knative-tutorial/knative-tutorial/serving/scaling.html#scaling-load-service)For more clarity and understanding let us [clean up](https://redhat-developer-demos.github.io/knative-tutorial/knative-tutorial/serving/scaling.html#scaling-cleanup) existing deployments before proceeding to next section.Either we have to remove this sentence or we should use
createfor the command I proposed. Here is the relevant page: https://redhat-developer-demos.github.io/knative-tutorial/knative-tutorial/serving/scaling.html#scaling-min-scale