Add console app to import a wsl distro from dockerhub #37
Conversation
| Hi, first of all, thanks a lot for this PR. Could you please provide me with some screenshots of how and if it works? I remember running into some issues (most of the Docker images were not importing properly) - do you see any of those issues on your end? |
|
|
| Regression tests on existing app |
| Overview of changes are: So then after copying, anything that didn't compile, I moved the signature into IPlatformHelper. I had to move some stuff out of DockerDownloader, because the Windows HttpRequestMessage doesn't appear to share any interface with System.Net.HttpRequestMessage. My main goal was to keep the UWP code as same as possible. I don't do any UWP development, so I didn't want to mess anything up. |
| Side note, multi platform images don't currently work. Looks like it will be easy enough to fix, but I didn't want to do to much in 1 PR, and I probably won't have time to touch it again until next weekend. If you want to do slack, discord, or comments here if anything isn't clear. I'm down for whatever. |
|
|
| string repository = ""; | ||
| string tag = ""; | ||
| string registry = "LLL"; | ||
| string registry = "registry-1.docker.io"; |
There was a problem hiding this comment.
I wasn't sure of the purpose of LLL, I could not get it to work with that value.
| I just want @wr0belj to take a second look on all of this. But, this is for sure a massive contribution. Thanks a lot. Please feel free to join our Discord server for our small community: https://discord.gg/NCdzvava7J |
| I thought this was a pretty neat project, happy to contribute. |
3 participants
I moved DockerDownloader and Helpers into a shared library. My goal was to make as minimum of changes as possible. So the things that were specific to store apps, I put into an interface rather than trying to make them more generic.