chore: use full control mode for webpack-config #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @haruelrovix could you take a look when you get the chance? Thanks :) |
haruelrovix approved these changes Oct 24, 2019
There was a problem hiding this comment.
Tested! No more DeprecationWarning 🎉
$ REALM=WEB start-storybook -p 6006 info @storybook/react v5.0.9 info info => Loading presets info => Loading presets info => Loading custom webpack config (full-control mode). info => Using base config because react-scripts is not installed. webpack built c283c8acb0c884587411 in 16532ms ╭────────────────────────────────────────────────────╮ │ │ │ Storybook 5.0.9 started │ │ 17 s for manager and 18 s for preview │ │ │ │ Local: http://localhost:6006/ │ │ On your network: http://192.168.43.140:6006/ │ │ │ ╰────────────────────────────────────────────────────╯ 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #3
Uses full-control mode for storybook webpack config