Fix textFilter() for Internet Explorer (includes() and find() are not supported) #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
NixonK force-pushed the fix_text_filter branch 7 times, most recently from f6db976 to 74a68e8 Compare NixonK changed the title 
AllenFang requested changes Mar 25, 2018
| filterValue = columns[keys[i]].filterValue; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think just use column.length will be much readable:
let filterValue; for (let i = 0; i < columns.length; i += 1) { if (columns[i].dataField === dataField) { filterValue = columns[keys[i]].filterValue; break; } }| sortedColumn = nextProps.columns[keys[i]]; | ||
| break; | ||
| } | ||
| } |
| @NixonK thanks your contributions, there's still tiny thing need to patch, thanks!! |
| @AllenFang Changes made, let me know if there's more, thank you! |
| @NixonK thanks your contribution 👍 |
| @NixonK BTW, could you please change to the |
NixonK force-pushed the fix_text_filter branch 2 times, most recently from b6a831b to f5eea7b Compare | @AllenFang Ah is the branch correct now? It is now rebased on top of origin/develop. ah woops deleted the branch. // reopened at #274 |
- replace includes() with indexOf() !== -1 - replace find() with for loop
- use .length of the columns instead of the Object.keys()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix textFilter() for Internet Explorer (includes() and find() are not supported)