Skip to content

Conversation

justincorrigible
Copy link

@justincorrigible justincorrigible commented Nov 10, 2020

Temporary workaround, for anyone who may come across this issue before this PR is merged:

use import ToolkitProvider from 'react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min'; instead.


Problem addressed:
As seen in MDN's web docs, an arrow function...

"Does not have arguments, or new.target keywords."

leading to this error when trying to import the toolkit package.

image

Uncaught ReferenceError: arguments is not defined


Edit for housekeeping: closes #1520


if (callNow) {
func.appy(this, arguments);
func.apply(this, args);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus: corrects typo

@justincorrigible
Copy link
Author

@AllenFang @Chun-MingChen For your consideration
Thanks for a great set of packages. Time saving and very useful!

@cjmaynar
Copy link

I saw this issue upon attempting to upgrade to Webpack 5; thanks for the PR! Would love to see this merged and released to allow this package to work with newest version of Webpack

@Sharpek
Copy link

Sharpek commented Feb 22, 2021

Any chance for release?

@itsmepetrov
Copy link

Hi @AllenFang and @chunming-c, could you please approve this PR and release a new version. I'm trying to upgrade webpack to v5 and this is the last thing which prevents me from that.

@janeksmielowski
Copy link

What is the chance for a release?

@MarlonAEC
Copy link

Hi folks!...Any news on this issue!? Cheers!

@juniorkibirige
Copy link

Error is back
Mix: Laravel Mix v6.0.13

@IlanFrumer
Copy link

Using this inside vitejs for now

 // vite.config.ts const modulesFolder = path.resolve(__dirname, 'node_modules/'); // ... resolve: { alias: { 'react-bootstrap-table2-toolkit-css': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css`, 'react-bootstrap-table2-toolkit': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.js`, '@': srcFolder, }, },
@erhanfirat
Copy link

PR is opened on Nov 10,
And I see as time passes new developers getting same error like me.
Don't you think to release?

@mah51
Copy link

mah51 commented Jul 21, 2021

Hi, I have also encountered this problem. Any chance of this being merged soon?

@afvieira
Copy link

afvieira commented Aug 2, 2021

Hi, I have also encountered this problem. Any chance of this being merged soon?

+1

@Jarvismkennedy
Copy link

Hi, I have also encountered this problem. Any chance of this being merged soon?

+1

@steveast
Copy link

steveast commented Oct 6, 2021

+1

@collynwalte
Copy link

I'm having this issue too

@jeremy-london
Copy link

Im having this issue can we get this MR reviewed and pushed please @AllenFang @itsmepetrov

The workaround in the MR description works, but we also needed to ignore some typescript pieces.. looking forward to updates

@Anonymous3105
Copy link

Can we get to know the timeline for the merge and release for this?
A lot of people (including me) are facing this issue. I tried the given workaround

use import ToolkitProvider from 'react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min'; instead.

But I'm still getting the same error.
Please provide the resolution for this.

@sheldonsebastian
Copy link

+1 on this issue

@jamesbaker1
Copy link

+1

4 similar comments
@xcarlosamm
Copy link

+1

@regis-samurai
Copy link

+1

@RuDami
Copy link

RuDami commented Mar 14, 2022

+1

@wcordelo
Copy link

+1

@duhmojo
Copy link

duhmojo commented Mar 15, 2022

+1 +1 +1 +1 +1

@DeDX3
Copy link

DeDX3 commented Mar 20, 2022

+1
I'm stuck here too. Used the link you gave but still same issue

@spookier
Copy link

+1

@duhmojo
Copy link

duhmojo commented Mar 21, 2022

FYI to all. The workaround by @IlanFrumer works for me. Added it to my resolve rebuilt and all is good again in the app.

Using this inside vitejs for now

 // vite.config.ts const modulesFolder = path.resolve(__dirname, 'node_modules/'); // ... resolve: { alias: { 'react-bootstrap-table2-toolkit-css': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css`, 'react-bootstrap-table2-toolkit': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.js`, '@': srcFolder, }, },

There should still be a release or a statement that the project is inactive. With no activity in nearly 2 years, yet still 70K downloads weekly, this module is an example case of a disaster waiting to happen. If its inactive, just state it so people know what they're getting into.

@RuDami
Copy link

RuDami commented Mar 21, 2022

okay, i'm used comment by duhmojo, but adapted for use with react-app-rewired && react-scripts.

  1. yarn add react-app-rewired

  2. package.json:

 "scripts": { "start": "react-app-rewired start --scripts-version react-scripts", "build": "react-app-rewired build --scripts-version react-scripts" } 
  1. in project root create config-overrides.js with
module.exports = function override(config, env) { if (!config.resolve) { config.resolve ={ alias: { "react/jsx-dev-runtime": "react/jsx-dev-runtime.js", "react/jsx-runtime": "react/jsx-runtime.js", 'react-bootstrap-table2-toolkit-css': `react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css`, 'react-bootstrap-table2-toolkit': `react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.js`, } }; }else { config.resolve = { ...config.resolve, alias: { ...config.resolve.alias, "react/jsx-dev-runtime": "react/jsx-dev-runtime.js", "react/jsx-runtime": "react/jsx-runtime.js", 'react-bootstrap-table2-toolkit-css': `react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css`, 'react-bootstrap-table2-toolkit': `react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.js`, } } } return config; } 
  1. yarn start

  2. ???

  3. PROFIT

@KevinGage
Copy link

This is preventing us from updating to react-scripts 5 due to the webpack 5 incompatibility. It seems like a small but critical patch. I'll echo what @duhmojo said. It sure looks like this project has been abandoned by its maintainers. If that's the case it would be great to know. Maybe someone would fork at that point.

rwbaskette added a commit to RoundtableLearning/react-bootstrap-table2 that referenced this pull request Apr 27, 2022
@alex-shepel
Copy link

To use with TypeScript import types separately.

import { ToolkitContextType } from 'react-bootstrap-table2-toolkit'; import ToolkitProvider from 'react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit'; <ToolkitProvider exportCSV {...tableProps}> {(props: ToolkitContextType) => ( // everything else )} </ToolkitProvider> 
@Swethasri1512
Copy link

Please anyone give me solution for this

@mustafaasif1
Copy link

Use "react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit" instead of "react-bootstrap-table2-toolkit" for importing of Components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment