- Notifications
You must be signed in to change notification settings - Fork 431
remove handleDebounce incorrect arguments from arrow functions #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
remove handleDebounce incorrect arguments from arrow functions #1506
Conversation
| ||
if (callNow) { | ||
func.appy(this, arguments); | ||
func.apply(this, args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus: corrects typo
@AllenFang @Chun-MingChen For your consideration |
I saw this issue upon attempting to upgrade to Webpack 5; thanks for the PR! Would love to see this merged and released to allow this package to work with newest version of Webpack |
Any chance for release? |
Hi @AllenFang and @chunming-c, could you please approve this PR and release a new version. I'm trying to upgrade webpack to v5 and this is the last thing which prevents me from that. |
What is the chance for a release? |
Hi folks!...Any news on this issue!? Cheers! |
Error is back |
Using this inside vitejs for now // vite.config.ts const modulesFolder = path.resolve(__dirname, 'node_modules/'); // ... resolve: { alias: { 'react-bootstrap-table2-toolkit-css': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css`, 'react-bootstrap-table2-toolkit': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.js`, '@': srcFolder, }, }, |
PR is opened on Nov 10, |
Hi, I have also encountered this problem. Any chance of this being merged soon? |
+1 |
+1 |
+1 |
I'm having this issue too |
Im having this issue can we get this MR reviewed and pushed please @AllenFang @itsmepetrov The workaround in the MR description works, but we also needed to ignore some typescript pieces.. looking forward to updates |
Can we get to know the timeline for the merge and release for this?
But I'm still getting the same error. |
+1 on this issue |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
+1 +1 +1 +1 +1 |
+1 |
+1 |
FYI to all. The workaround by @IlanFrumer works for me. Added it to my resolve rebuilt and all is good again in the app.
There should still be a release or a statement that the project is inactive. With no activity in nearly 2 years, yet still 70K downloads weekly, this module is an example case of a disaster waiting to happen. If its inactive, just state it so people know what they're getting into. |
okay, i'm used comment by duhmojo, but adapted for use with react-app-rewired && react-scripts.
|
This is preventing us from updating to react-scripts 5 due to the webpack 5 incompatibility. It seems like a small but critical patch. I'll echo what @duhmojo said. It sure looks like this project has been abandoned by its maintainers. If that's the case it would be great to know. Maybe someone would fork at that point. |
Applies pull request react-bootstrap-table#1506 from the original repo: react-bootstrap-table#1506
To use with TypeScript import types separately.
|
Please anyone give me solution for this |
Use "react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit" instead of "react-bootstrap-table2-toolkit" for importing of Components. |
Temporary workaround, for anyone who may come across this issue before this PR is merged:
use
import ToolkitProvider from 'react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min';
instead.Problem addressed:
As seen in MDN's web docs, an arrow function...
leading to this error when trying to import the toolkit package.
Uncaught ReferenceError: arguments is not defined
Edit for housekeeping: closes #1520