Pivot Table support #1385

[eitens-mak]

Supporting #1385

Needs some more testing and cleanup, but basic functionality is working in the storybook

[eitens-mak]

One test is failing, but it's also failing in the master branch,

Summary of all failing tests FAIL packages/react-bootstrap-table2/test/store/sort.test.js ● Sort Function › sort › should call custom sort function when sortFunc given expect(received).toBe(expected) Expected value to be (using ===): 6 Received: 3 at Object.<anonymous> (packages/react-bootstrap-table2/test/store/sort.test.js:48:34) at new Promise (<anonymous>) at node_modules/p-map/index.js:46:16 at processTicksAndRejections (internal/process/task_queues.js:97:5) 

[eitens-mak]

@Chun-MingChen I think you are a maintainer. Anything else to fix so this could be merged?

[AllenFang]

@eitens-mak I will review it, thanks

[AllenFang]

BTW, @eitens-mak please change the base to develop branch, master is for release. thanks

[AllenFang]

any reason why upgrade node-sass?

[eitens-mak]

I forget exactly, but I think I couldn't get the dev environment to build on Ubuntu 18.04

[eitens-mak]

Updated the base branch

[AllenFang]

thanks!

[eitens-mak]

Anything else to do on this?

…

On Sat, Jul 18, 2020, 22:48 Allen ***@***.***> wrote: thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1401 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMWNIOVDSEM72EL7XSWF2O3R4KCJDANCNFSM4OBILZJQ> .