Row expand animation v2 #1289
Open
Row expand animation v2 #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
"appear" was no longer being triggered, changed it to "active" instead
- Now supports any content height - Smoother animation
- Animation is on by default - 'animate' property in expandRow prop
shp7724 approved these changes Mar 31, 2020
| Hi! Was this already merged in the latest build in NPM? Thanks! |
| @keanpaderes No, the PR is still open |
| Sorry, I was busy recently. I will merge this ASAP, thanks |
| Are you doing the testing on storybook? I tested on the row expand stories (on chrome) and they work perfectly fine. |
| @YassienW yes, I test it on chrome by storybook! |
| @AllenFang Is there any update on this ? Can you show us the error you got ? It's really frustrating not being able to disable animations when they are not working properly. |
| @rodricarranza Can you help by testing it on your end? It's very weird that it's working fine on my end but @AllenFang is having issues, not sure how to replicate. |
| Hi, is there any update on this? Could I help in any way? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Improved row expansion animation (#912):
animateprop to disable animation (true by default)Added storybook page for
animatepropFurther testing would be appreciated.