Skip to content

Conversation

@lwasser
Copy link
Member

@lwasser lwasser commented Sep 13, 2022

This PR does a few things

  1. it remove the "we are on pause" language so we can begin accepting submissions again
  2. It adds a date accepted to the yaml to allow us to better track acceptance of packages. this will be useful for database purpose and website publishing
  3. requests a list of all maintainers of the package. i realized most packages have more than 1 and having all of them in our database is useful for many reasons. also we would invite them all to slack and promote them all on twitter.

NOTE: there is a quirk where the markdown isn't rendering the way that we want it to as a list without bullets but the template itself is fine - i've checked it in several text editors.

in the FUTURE could be worth considering a better template like this: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository but that might be at the risk of losing parsability like what ROS uses

@lwasser
Copy link
Member Author

lwasser commented Sep 14, 2022

@NickleDave or @xmnlab can one of you please have a look at this and approve or comment? 🙌

@lwasser lwasser changed the title Removing we are on pause Removing we are on pause from the submission template Sep 14, 2022
Copy link

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @lwasser

@NickleDave NickleDave merged commit ff6e1ed into main Sep 14, 2022
@Batalex Batalex deleted the remove-on-pause-add-date branch April 12, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants